Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: QueryExecutorBean can throw INVALID_MAX_RESULTS_OVERRIDE error when it shouldn't #2251

Closed
keith-ratcliffe opened this issue Jan 31, 2024 · 0 comments · Fixed by #2252
Closed

Bug: QueryExecutorBean can throw INVALID_MAX_RESULTS_OVERRIDE error when it shouldn't #2251

keith-ratcliffe opened this issue Jan 31, 2024 · 0 comments · Fixed by #2252
Assignees
@keith-ratcliffe
Labels
bug Something isn't working

Comments

@keith-ratcliffe
Copy link
Collaborator

keith-ratcliffe commented Jan 31, 2024 •
edited

Bug 1
If the user specifies a max.results.override that exceeds max results for the given QueryLogic, DatawaveErrorCode.INVALID_MAX_RESULTS_OVERRIDE will be thrown in validateQuery even though the override should be permissible based on other configured overrides, such as those defined for specific DN and/or systemFrom values

Bug 2
There is an additional bug on the line above that would cause DatawaveErrorCode.INVALID_MAX_RESULTS_OVERRIDE to be thrown for users with the UNLIMITED_QUERY_RESULTS_USER role, if they do not also possess the PRIVILEGED_USER role
@keith-ratcliffe keith-ratcliffe added the bug Something isn't working label Jan 31, 2024
keith-ratcliffe added a commit that referenced this issue Jan 31, 2024
@keith-ratcliffe
Fixes QEB's max results override validation (#2251)
c45ccea
keith-ratcliffe added a commit that referenced this issue Jan 31, 2024
@keith-ratcliffe
Fixes QEB's max results override validation (#2251)
2c2ac2d
keith-ratcliffe added a commit that referenced this issue Jan 31, 2024
@keith-ratcliffe
Fixes QEB's max results override validation (#2251)
f09a53c
@keith-ratcliffe keith-ratcliffe mentioned this issue Jan 31, 2024
Merged
keith-ratcliffe added a commit that referenced this issue Jan 31, 2024
@keith-ratcliffe
Fixes QEB's max results override validation (#2251)
e7c7774
keith-ratcliffe added a commit that referenced this issue Feb 5, 2024
@keith-ratcliffe
Fixes QEB's max results override validation (#2251)
30e0e7d
@keith-ratcliffe keith-ratcliffe self-assigned this Feb 5, 2024
@keith-ratcliffe keith-ratcliffe linked a pull request Feb 5, 2024 that will close this issue
Fixes QEB's max results override validation (#2251) #2252
Merged
hgklohr added a commit that referenced this issue Feb 23, 2024
@keith-ratcliffe @hgklohr
Fixes QEB's max results override validation (#2251) (#2252)
a49c170 
Co-authored-by: hgklohr <hgklohr@gmail.com>
hgklohr added a commit that referenced this issue Feb 23, 2024
@keith-ratcliffe @hgklohr
Fixes QEB's max results override validation (#2251) (#2252)
36c9e9a 
Co-authored-by: hgklohr <hgklohr@gmail.com>
hgklohr added a commit that referenced this issue Feb 23, 2024
@keith-ratcliffe @hgklohr
Fixes QEB's max results override validation (#2251) (#2252)
60633d8 
Co-authored-by: hgklohr <hgklohr@gmail.com>
hgklohr added a commit that referenced this issue Feb 23, 2024
@keith-ratcliffe @hgklohr
Fixes QEB's max results override validation (#2251) (#2252)
4d2689a 
Co-authored-by: hgklohr <hgklohr@gmail.com>
hgklohr added a commit that referenced this issue Feb 23, 2024
@keith-ratcliffe @hgklohr
Fixes QEB's max results override validation (#2251) (#2252)
c50d24c 
Co-authored-by: hgklohr <hgklohr@gmail.com>
drewfarris pushed a commit that referenced this issue Feb 29, 2024
@keith-ratcliffe @hgklohr @drewfarris
Fixes QEB's max results override validation (#2251) (#2252)
42c97ea 
Co-authored-by: hgklohr <hgklohr@gmail.com>
@keith-ratcliffe keith-ratcliffe mentioned this issue Mar 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@keith-ratcliffe keith-ratcliffe

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes QEB's max results override validation (#2251) NationalSecurityAgency/datawave
1 participant
@keith-ratcliffe