Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MATCHES_IN_GROUP should work with a number #2400

Closed
ivakegg opened this issue Jun 4, 2024 · 0 comments · Fixed by #2434
Closed

MATCHES_IN_GROUP should work with a number #2400

ivakegg opened this issue Jun 4, 2024 · 0 comments · Fixed by #2434
Assignees

Comments

@ivakegg
Copy link
Collaborator

ivakegg commented Jun 4, 2024

If you do something like $MATCHES__IN_GROUP(field1,value1,field2,10) where field2 is typed as a number, and the value is a number (10 in this case), then the query will fail as follows:

Caused by : ...JexlException: ...JexlEvaluation... (grouping:matchesInGroup(field1,value1,field2,+bE1) method invocation error
Caused by: java.util.regex.PatternSyntaxException: Dangling meta charater '+' nead index 0 +bE1

Basically, we need to normalize the values into a regex.

This may bring up a larger issue of when a user supplies a raw number where a regex is required, we need to think about how to handle that case.

lbschanno added a commit that referenced this issue Jun 25, 2024
Enable regex matching for functions in
GroupingRequiredFilteredFunctions. Increase test coverage. Verify
numeric regex matching works. Update existing unit tests in anticipating
of merging in datawave-type-utils/pull/11 which makes changes to how
numeric regexes are normalized.

Fixes #2400
ivakegg added a commit that referenced this issue Jun 26, 2024
@ivakegg ivakegg closed this as completed in cfa8731 Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants