-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/composite timestamp #2187
Open
hlgp
wants to merge
14
commits into
integration
Choose a base branch
from
feature/compositeTimestamp
base: integration
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivakegg
reviewed
Feb 7, 2024
ivakegg
reviewed
Feb 7, 2024
warehouse/core/src/main/java/datawave/util/CompositeTimestamp.java
Outdated
Show resolved
Hide resolved
ivakegg
reviewed
Feb 7, 2024
warehouse/core/src/main/java/datawave/util/CompositeTimestamp.java
Outdated
Show resolved
Hide resolved
ivakegg
reviewed
Feb 7, 2024
warehouse/core/src/main/java/datawave/util/CompositeTimestamp.java
Outdated
Show resolved
Hide resolved
ivakegg
reviewed
Feb 7, 2024
warehouse/core/src/main/java/datawave/util/CompositeTimestamp.java
Outdated
Show resolved
Hide resolved
ivakegg
reviewed
Feb 7, 2024
* Refined the composite timestamp to check for bounds Added a few tests as such * Allow negative event dates * More tests * add more tests * formatter --------- Co-authored-by: hlgp <hlgp@users.noreply.github.com>
* Add get and set Timestamp on the record container. * Override getDate to be compatible with extending classes * Updated sharded ingest to appropriately use getTimestamp vs getDate * Updated index table to use composite timestamp * Added an explicit INVALID_TIMESTAMP instead of using Long.MIN_VALUE to determine if the date is not set * Updated the global index uid aggregator to not aggregate across different timestamps * Removed the "timestampIgnored" flag on the global index uid aggregator as we never turn that off and we don't want to * Added test to ensure that keys with different timestamps do not get aggregated
…tween the start-of-day values for the event and age off dates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.