Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

re #2239: clear the document before exiting the method. #2240

Merged
merged 2 commits into from
Jan 31, 2024
Merged

re #2239: clear the document before exiting the method. #2240

merged 2 commits into from
Jan 31, 2024

Conversation

d-hwang
Copy link
Collaborator

@d-hwang d-hwang commented Jan 30, 2024

empty keys are expected in some cases

@d-hwang d-hwang added Integration Tested bug Something isn't working labels Jan 30, 2024
drewfarris
drewfarris previously approved these changes Jan 30, 2024
View reviewed changes
FineAndDandy
FineAndDandy requested changes Jan 30, 2024
View reviewed changes
Copy link
Collaborator

@FineAndDandy FineAndDandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we have a bare bones unit test for this issue?

ivakegg
ivakegg previously approved these changes Jan 30, 2024
View reviewed changes
@d-hwang d-hwang dismissed stale reviews from ivakegg and drewfarris via 6468b22 January 30, 2024 18:12
ivakegg
ivakegg previously approved these changes Jan 30, 2024
View reviewed changes
drewfarris
drewfarris previously approved these changes Jan 30, 2024
View reviewed changes
apmoriarty
apmoriarty previously approved these changes Jan 30, 2024
View reviewed changes
hlgp
hlgp previously approved these changes Jan 30, 2024
View reviewed changes
@apmoriarty apmoriarty dismissed stale reviews from hlgp, drewfarris, ivakegg, and themself via 7957254 January 31, 2024 12:41
@d-hwang d-hwang mentioned this pull request Jan 31, 2024
Closed
@hgklohr hgklohr merged commit d3bfb12 into release/version5.11 Jan 31, 2024
3 checks passed
@FineAndDandy
Copy link
Collaborator

Thanks @apmoriarty for adding the unit test

@apmoriarty apmoriarty deleted the issue-2239 branch February 1, 2024 09:30
hgklohr pushed a commit that referenced this pull request Feb 2, 2024
@d-hwang @apmoriarty @hgklohr
re #2239: clear the document before exiting the method. (#2240)
a3b53eb 
* re #2239: clear the document before exiting the method. empty keys are expected in some cases

* Add unit test for TermOffsetPopulator

---------

Co-authored-by: Moriarty <22225248+apmoriarty@users.noreply.github.com>
hgklohr pushed a commit that referenced this pull request Feb 2, 2024
@d-hwang @apmoriarty @hgklohr
re #2239: clear the document before exiting the method. (#2240)
4821b43 
* re #2239: clear the document before exiting the method. empty keys are expected in some cases

* Add unit test for TermOffsetPopulator

---------

Co-authored-by: Moriarty <22225248+apmoriarty@users.noreply.github.com>
hgklohr pushed a commit that referenced this pull request Feb 2, 2024
@d-hwang @apmoriarty @hgklohr
re #2239: clear the document before exiting the method. (#2240)
cc66916 
* re #2239: clear the document before exiting the method. empty keys are expected in some cases

* Add unit test for TermOffsetPopulator

---------

Co-authored-by: Moriarty <22225248+apmoriarty@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FineAndDandy FineAndDandy FineAndDandy requested changes

@drewfarris drewfarris drewfarris approved these changes

@jack-gitdev jack-gitdev jack-gitdev approved these changes

@ivakegg ivakegg ivakegg left review comments

@apmoriarty apmoriarty apmoriarty left review comments

@hlgp hlgp hlgp left review comments

Assignees
No one assigned
Labels
bug Something isn't working Integration Tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@d-hwang @FineAndDandy @drewfarris @ivakegg @apmoriarty @hlgp @jack-gitdev @hgklohr