Enforce term limits during EdgeQueries #2274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apmoriarty
reviewed
Feb 8, 2024
...use/query-core/src/main/java/datawave/query/jexl/visitors/EdgeTableRangeBuildingVisitor.java
Outdated
Show resolved
Hide resolved
apmoriarty
previously approved these changes
Feb 8, 2024
apmoriarty
previously approved these changes
Feb 8, 2024
jschmidt10
force-pushed
the
bugfix/edge_term_limit
branch
from
719bc9e
to
eb028be
Compare
ivakegg
previously approved these changes
Feb 8, 2024
ivakegg
approved these changes
Feb 8, 2024
keith-ratcliffe
approved these changes
Feb 8, 2024
ivakegg
pushed a commit
that referenced
this pull request
Feb 8, 2024
* Enforce term limits during EdgeQueries * Update error message * Fix EdgeQuery maxQueryTerms setting
ivakegg
pushed a commit
that referenced
this pull request
Feb 8, 2024
* Enforce term limits during EdgeQueries * Update error message * Fix EdgeQuery maxQueryTerms setting
ivakegg
pushed a commit
that referenced
this pull request
Feb 8, 2024
* Enforce term limits during EdgeQueries * Update error message * Fix EdgeQuery maxQueryTerms setting
rdhayes68
pushed a commit
that referenced
this pull request
Feb 21, 2024
* Enforce term limits during EdgeQueries * Update error message * Fix EdgeQuery maxQueryTerms setting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently do not limit terms correctly for EdgeQueries due to the condition being checked in the parent AND or OR node before we have visited the terms and incremented the termCount.
Updated to increment the term count and check as we go.