Fix lineage for FacetCheck #956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FacetCheck does not return a query tree with a valid lineage. Ensure that lineage is properly established and add unit tests to assert this. Part of #880.
lbschanno
requested review from
alerman,
apmoriarty,
billoley,
cawaring,
drewfarris,
hlgp,
ivakegg,
jschmidt10,
jwomeara,
keith-ratcliffe and
matthpeterson
as code owners
ivakegg
requested changes
Oct 21, 2020
warehouse/query-core/src/main/java/datawave/query/tables/facets/FacetCheck.java
Outdated
Show resolved
Hide resolved
|
@drewfarris please take a look at this one if you can. |
ivakegg
approved these changes
Oct 29, 2020
|
Do we want to hold off for @drewfarris or just merge this one in? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FacetCheck does not return a query tree with a valid lineage. Ensure
that lineage is properly established and add unit tests to assert this.
Part of #880.