Verify lineage for ExpandMultinormalizedTerms #958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an assert to tests for ExpandMultinormalizedTerms to verify that it returns a query tree with valid lineage. Part of #880.
lbschanno
requested review from
alerman,
apmoriarty,
billoley,
cawaring,
drewfarris,
hlgp,
ivakegg,
jschmidt10,
jwomeara,
keith-ratcliffe and
matthpeterson
as code owners
ivakegg
previously approved these changes
Oct 21, 2020
jwomeara
requested changes
Oct 30, 2020
warehouse/query-core/src/main/java/datawave/query/jexl/visitors/ExpandMultiNormalizedTerms.java
Outdated
Show resolved
Hide resolved
jwomeara
previously approved these changes
Oct 30, 2020
ivakegg
requested changes
Nov 2, 2020
warehouse/query-core/src/main/java/datawave/query/jexl/JexlASTHelper.java
Outdated
Show resolved
Hide resolved
jwomeara
requested changes
Nov 3, 2020
warehouse/query-core/src/main/java/datawave/query/jexl/JexlASTHelper.java
Outdated
Show resolved
Hide resolved
|
Per a request from @ivakegg earlier today, I've moved the isDelayedPredicate() method to QueryPropertyMarkerVisitor. |
ivakegg
requested changes
Nov 10, 2020
warehouse/query-core/src/main/java/datawave/query/jexl/JexlASTHelper.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an assert to tests for ExpandMultinormalizedTerms to verify that it
returns a query tree with valid lineage.
Part of #880.