Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emissary-171: addressed most easily remedied CodeQL security findings #173

Merged
merged 2 commits into from
Sep 29, 2021

Conversation

drivenflywheel
Copy link
Collaborator

@drivenflywheel drivenflywheel commented Sep 28, 2021

Address CodeQL security findings. (Partially) addresses #171

@drivenflywheel
Copy link
Collaborator Author

drivenflywheel commented Sep 28, 2021

This commit addresses the following 10 alerts:

Second commit resolves the following alert:

@@ -287,42 +287,6 @@ public String getOutputDirectory() {
return this.placeOutputData;
}

public String getOutputDirectory(final IBaseDataObject DO) {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified that there were no references to this overload in downstream repositories.

@jpdahlke jpdahlke added this to the v7.1.0 milestone Sep 29, 2021
@cfkoehler cfkoehler self-requested a review September 29, 2021 15:13
@cfkoehler cfkoehler added the security There are security/vulnerability implications label Sep 29, 2021
@jpdahlke jpdahlke merged commit 9b185ce into NationalSecurityAgency:master Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
security There are security/vulnerability implications
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants