-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding objectTrace logger to output configurable fields to a new log file from PickUpPlace #530
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am good with this once the one comment I left is resolved.
I imported this into our other project and messed with the overrides and such and all worked as I would expect
The Super-Linter job keeps failing: "DOCKERFILE_HADOLINT_LINTER_RULES rules file (/action/lib/.automation/../../contrib/docker/.hadolint.yaml) doesn't exist. Terminating..." This may be an issue with the job itself - I saw it was updated recently. I'm not sure why my 1-line change would have caused this issue if it passed before. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would like to see the implementation better encapsulated so Places can integrate with less coupling.
If we think the events we emit we may need to have environment-specific fields, we should consider using the Service Provider pattern that leverages the support we have in the |
I'm investigating this, not sure if it is best to do in this PR or a follow-up PR. |
|
No description provided.