Removing date parsing bug workaround #613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbruton
approved these changes
Dec 28, 2023
drivenflywheel
approved these changes
Dec 29, 2023
jpdahlke
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There two few issues with date parsing in java 8 that should be resolved in java 11. The point of this ticket is to make sure our date parsing code no longer has issues so we can move over to using the DateTimeFormatter from SimpleDateFormat.
FlexibleDateTimeParser has a custom workaround of removing offsets from date strings due to an issue with parsing date strings with a time zone and an offset in java 8. The previous behavior would ignore the offset and use the timezone, so we added a custom solution to strip out the three-letter time zone. Now that we are using java11, the modifications are no longer needed so remove this workaround.
http://bugs.java.com/bugdatabase/view_bug.do?bug_id=8032051. Added a test to make sure our code is successfully able to parse dates that have a shorter offset.