Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve LogBackTester interface #620

Merged
merged 9 commits into from
Nov 29, 2023

Conversation

nixon124
Copy link
Collaborator

@nixon124 nixon124 commented Nov 3, 2023

Improved interface of LogBackTester and created test to test LogBackTester.

@drivenflywheel drivenflywheel changed the title ImprovLGTester Improve LogBackTester interface Nov 3, 2023
Copy link
Collaborator

@drivenflywheel drivenflywheel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent start. Some minor cleanup suggestions

@jdcove2 jdcove2 added the test-only The change only impacts test code label Nov 15, 2023
@jpdahlke jpdahlke added this to the v8.0.0-M10 milestone Nov 29, 2023
@jpdahlke jpdahlke merged commit 2bf7b00 into NationalSecurityAgency:master Nov 29, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test-only The change only impacts test code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants