Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sentinel updates and add tests #631

Merged
merged 10 commits into from
Dec 12, 2023
Merged

sentinel updates and add tests #631

merged 10 commits into from
Dec 12, 2023

Conversation

dev-mlb
Copy link
Collaborator

@dev-mlb dev-mlb commented Dec 6, 2023

No description provided.

@dev-mlb dev-mlb marked this pull request as ready for review December 7, 2023 18:22
@jpdahlke jpdahlke modified the milestones: v8.0.0-M12, v8.0.0-M11 Dec 7, 2023
jpdahlke
jpdahlke requested changes Dec 11, 2023
View reviewed changes
Copy link
Collaborator

@jpdahlke jpdahlke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change look good, just minor nits.

src/main/java/emissary/core/sentinel/protocols/Protocol.java Outdated Show resolved Hide resolved
@cfkoehler cfkoehler self-requested a review December 11, 2023 17:47
@jpdahlke jpdahlke merged commit 642fa24 into NationalSecurityAgency:master Dec 12, 2023
9 checks passed
@jpdahlke jpdahlke added the enhancement An enhancement to an existing feature label Dec 12, 2023
@dev-mlb dev-mlb deleted the sentinel branch December 13, 2023 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpdahlke jpdahlke jpdahlke approved these changes

@cfkoehler cfkoehler cfkoehler approved these changes

Assignees
No one assigned
Labels
enhancement An enhancement to an existing feature
Projects
None yet
Milestone
v8.0.0-M11
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dev-mlb @jpdahlke @cfkoehler