Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update error-prone, patterns, and compiler config #648

Merged
merged 3 commits into from
Jan 19, 2024

Conversation

jpdahlke
Copy link
Collaborator

Updates error-prone and sets us up to hopefully clear the issues and activate this by default to fail builds.

Here are the outstanding issues needing attentions based on this PR:

     23 [MemberName]
     13 [SystemOut]
     10 [ReturnMissingNullable]
      8 [FieldMissingNullable]
      5 [YodaCondition]
      4 [NonFinalStaticField]
      4 [MissingSummary]
      4 [ConstantField]
      4 [BooleanParameter]
      3 [CatchingUnchecked]
      2 [UnnecessarilyFullyQualified]
      2 [UngroupedOverloads]
      2 [ThreadPriorityCheck]
      2 [ParameterMissingNullable]
      2 [NotJavadoc]
      2 [CheckedExceptionNotThrown]
      2 [AvoidObjectArrays]
      1 [UnnecessaryParentheses]
      1 [ReturnsNullCollection]
      1 [MissingOverride]
      1 [MethodCanBeStatic]
      1 [JdkObsolete]
      1 [Interruption]
      1 [FieldCanBeFinal]
      1 [EqualsGetClass]

@jpdahlke jpdahlke added dependencies This updates a dependency version tech-debt Low-impact cleanup and upkeep labels Jan 16, 2024
@jpdahlke jpdahlke added this to the v8.0.0-M13 milestone Jan 16, 2024
@jpdahlke
Copy link
Collaborator Author

jpdahlke commented Jan 16, 2024

  • available internally

@jpdahlke jpdahlke requested a review from dev-mlb January 16, 2024 17:57
pom.xml Outdated Show resolved Hide resolved
Copy link
Collaborator

@sambish5 sambish5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jpdahlke jpdahlke removed the request for review from dev-mlb January 19, 2024 15:24
@jpdahlke jpdahlke merged commit edf7ba5 into NationalSecurityAgency:master Jan 19, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies This updates a dependency version tech-debt Low-impact cleanup and upkeep
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants