Remove IBaseDataObjectHelper.setPrivateFieldValue() method. #656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Edit: for some reason I was able to fetch this PR from a different repository, which resulted in some breaking issues. Actually pulling down the PR into my emissary repo resulted in a successful build. |
SemperFidelisTyrannosaurus
previously approved these changes
Feb 5, 2024
jpdahlke
dismissed stale reviews from SemperFidelisTyrannosaurus and sambish5
via
3663946
sambish5
approved these changes
Feb 13, 2024
SemperFidelisTyrannosaurus
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the IBaseDataObjectHelper.setPrivateFieldValue() method, which uses reflection, and replaces it with equivalent code that does not use reflection.