Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addressing auto-closeable warnings #686

Merged

Conversation

nixon124
Copy link
Collaborator

@nixon124 nixon124 commented Feb 8, 2024

Decided to remove the try-with-resources blocks altogether to resolve the build warnings. If needed, I can make them try-finally so that there aren't any "explicit call to close()" warnings.

@cfkoehler cfkoehler added this to the v8.0.0-M14 milestone Feb 9, 2024
@cfkoehler
Copy link
Collaborator

@nixon124 pipeline and local build shows that the formatter needs to be run and those changes committed.

@jpdahlke jpdahlke added the test-only The change only impacts test code label Feb 10, 2024
@jpdahlke jpdahlke self-requested a review February 10, 2024 15:26
@jpdahlke jpdahlke merged commit 9a477d0 into NationalSecurityAgency:master Feb 10, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test-only The change only impacts test code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants