Have DropOffPlace stop calling IBDO.data()/IBDO.dataLength(). #709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbruton
reviewed
Mar 5, 2024
drivenflywheel
approved these changes
Mar 21, 2024
cfkoehler
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the IBDO.data() call with IBDO.getChannelFactory() and IBDO.dataLength() call with IBDO.getChannelSize().
This allows DropOffPlace to determine if the data is null without incurring the cost of creating a byte array every time it is not null and correctly outputs the size of objects that are greater than 2^31.