Excluding BooleanParameter from error-prone warnings #713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpdahlke
requested changes
Feb 29, 2024
jpdahlke
approved these changes
Feb 29, 2024
drivenflywheel
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parent issue: https://github.com/NationalSecurityAgency/burrito-grande/issues/2600
Excluding
BooleanParametererror-prone warnings.BooleanParameter is just adding comments to things like
runTest(800L, 1500L, 200L, 100L, /* simple= */true);so that you know what the boolean is referencing, but this just makes the code messier, and really is not necessary at all.