Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executrix :: binary mode #756

Merged
merged 4 commits into from
Apr 23, 2024

Conversation

dev-mlb
Copy link
Collaborator

@dev-mlb dev-mlb commented Apr 12, 2024

No description provided.

@dev-mlb dev-mlb marked this pull request as ready for review April 16, 2024 14:25
drivenflywheel
drivenflywheel previously approved these changes Apr 18, 2024
@rpg36 rpg36 self-requested a review April 19, 2024 14:52
@jpdahlke jpdahlke added this to the v8.2.0 milestone Apr 19, 2024
Copy link
Collaborator

@rpg36 rpg36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems ok to me but should there be some unit test updates? The code coverage isn't super great for Executrix or ReadOutputBuffer.

Copy link
Collaborator

@drivenflywheel drivenflywheel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor, just cleanup of wildcard imports

@jpdahlke jpdahlke merged commit ed1ac9c into NationalSecurityAgency:main Apr 23, 2024
12 checks passed
@dev-mlb dev-mlb deleted the executrix-binary-mode branch May 2, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants