Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

errorprone :: ProtectedMembersInFinalClass #794

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ private LazyFileChannelImpl(final Path path) {
this.path = path;
}

protected void initialiseChannel() throws IOException {
void initialiseChannel() throws IOException {
if (channel == null) {
channel = FileChannel.open(path, OPTIONS);
}
Expand Down
12 changes: 6 additions & 6 deletions src/main/java/emissary/pickup/WorkBundle.java
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,7 @@ public String getBundleId() {
*
* @return the new id value
*/
protected static String generateId() {
static String generateId() {
return UUID.randomUUID().toString();
}

Expand Down Expand Up @@ -325,7 +325,7 @@ public int addWorkUnit(WorkUnit workUnit, long fileModificationTimeInMillis, lon
* @throws IllegalStateException if adding the units would cause the bundle to contain more than <code>MAX_UNITS</code>
* work units
*/
protected int addWorkUnits(List<WorkUnit> list) { // This appears to only be used by unit tests and the copy constructor
int addWorkUnits(List<WorkUnit> list) { // This appears to only be used by unit tests and the copy constructor
if (workUnitList.size() + list.size() > MAX_UNITS) {
throw new IllegalStateException("WorkBundle may not contain more than " + MAX_UNITS + " WorkUnits.");
}
Expand Down Expand Up @@ -390,7 +390,7 @@ public int addFileName(String file, long fileModificationTimeInMillis, long file
* @throws IllegalStateException if adding the files would cause the bundle to contain more than <code>MAX_UNITS</code>
* work units
*/
protected int addFileNames(String[] file) { // This appears to only be used by unit tests
int addFileNames(String[] file) { // This appears to only be used by unit tests
for (String f : file) {
addWorkUnit(new WorkUnit(f));
}
Expand All @@ -404,8 +404,8 @@ protected int addFileNames(String[] file) { // This appears to only be used by u
* @throws IllegalStateException if adding the files would cause the bundle to contain more than <code>MAX_UNITS</code>
* work units
*/
protected int addFileNames(List<String> list) { // This appears to only be used by unit tests and the copy
// constructor
int addFileNames(List<String> list) { // This appears to only be used by unit tests and the copy
// constructor
for (String file : list) {
addWorkUnit(new WorkUnit(file));
}
Expand All @@ -422,7 +422,7 @@ public int size() {
/**
* Clear the files from the list
*/
protected void clearFiles() {
void clearFiles() {
// This is only used for testing
workUnitList.clear();
oldestFileModificationTime = Long.MAX_VALUE;
Expand Down