Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set settings for highlighting in the ByteViewerComponent #1465

Merged
merged 1 commit into from
Jan 21, 2020
Merged

Set settings for highlighting in the ByteViewerComponent #1465

merged 1 commit into from
Jan 21, 2020

Conversation

saruman9
Copy link
Contributor

Fix #1464

@dragonmacher dragonmacher self-requested a review January 21, 2020 16:25
dragonmacher
dragonmacher approved these changes Jan 21, 2020
View reviewed changes
Copy link
Collaborator

@dragonmacher dragonmacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is consistent with the rest of the options settings.

@GhidorahRex GhidorahRex added this to the 9.2 milestone Jan 21, 2020
@GhidorahRex GhidorahRex merged commit 85e50a1 into NationalSecurityAgency:master Jan 21, 2020
GhidorahRex added a commit that referenced this pull request Jan 21, 2020
@GhidorahRex
Merge remote-tracking branch
b953141 
'origin/GT-3471_dragonmacher_PR-1465_saruman9_fix_byte_viewer_highlight'

Fixes #1464, fixes #1465
@saruman9 saruman9 deleted the fix_byte_viewer_highlight branch January 22, 2020 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dragonmacher dragonmacher dragonmacher approved these changes

Assignees
No one assigned
Labels
Feature: Byte Viewer
Projects
None yet
Milestone
9.2
Development

Successfully merging this pull request may close these issues.

Highlight settings don't apply in ByteViewer
4 participants
@saruman9 @dragonmacher @ryanmkurtz @GhidorahRex