Provide a basic .desktop file for Linux #1556
Conversation
|
Small question, where exactly does the |
|
I tested with the GhidraIcon*.png files that are used for the taskbar icon as well. As far as I could tell, every one of those icon sizes worked fine. One possible path where that image might be placed (so that it is picked up without a full path) is EDIT: By the way, I'm not sure whether my code to copy out the .desktop file would work in practice. If someone could take a look at that specifically that would be nice. |
|
Thinking about it, copying out one of those images next to the .desktop file would be beneficial to people who build packages from the official release package alone (since as far as I know, the files I linked earlier are embedded into the executable as a resource and not easily accessible). Also, .ico files do not work. While they are correctly picked up by the image search, the inclusion of multiple resolutions in the same file seems to create issues when rendering (causing some distortion or even an image completely filled with static). |
|
Here is common system-wide implementation tested working on Arch Linux /usr/share/applications/Ghidra.desktop
Icons (from Generic.jar also attached in ghidra.zip)
This is a great idea. In my opinion this would standardize the package with what is usually done with others, and the icons are pretty cool well done :) I initially asked the Arch Linux package maintainer to do that because I first thought this was Arch maintainer responsibility to do that but they asked to report upstream. What do you think guys, is it implementable this way ? PS1: Also I'm not sure it has been implemented in 9.2.1, as of writing Arch Linux package is still on 9.2 and is missing this. PS2: you might need to refresh the icon cache on your system after moving the icon files
|
|
We do not plan to include a .desktop file in our release at this time. |
ryanmkurtz
added
the
Reason: Won't support
Some distributions started to adopt Ghidra into their package repositories, but won't include a .desktop file due to upstream not providing one.
Since Ghidra doesn't have a set default installation location, this .desktop file needs either modification on the users end (to include the full path) or the
ghidraRunscript has to be present in the search PATH (in addition to the icon being present in one of the icon search directories/providing a full path to that as well).