Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the call tree of
openDocument() -> parseDocument() -> xml_tree() -> xml_parse()
, the global variablesglobal_scan
andhandler
are set.When
openDocument()
is used in a multithreaded environment, both variables are modified without a thread locking mechanism.This was discovered while implementing bindings to the sleigh library and is a reproducible SIGSEGV as tracked by angr/pypcode#30
The fixes in this PR are ported from sleighcraft.