Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of a research project testing the accuracy of the sleigh specifications compared to real hardware, we observed a difference in the disassembly of various instructions in the compressed extension. The
c.jr
,c.addiw
,c.lwsp
,c.ldsp
,c.lqsp
all successfully decode when the rd register is zero, although this encoding is reserved for future use. To prevent this anzcrd
register has been added which excludes the zero register, and these instructions have been changed to use it.The
c.nop
instruction encodes hardware hints when the immediate field is non-zero. Section 2.9 of the riscv-spec-20191213 describes hardware hints as ignore-able on hardware that does not support them as they do not change any architecturally visible state, except for advancing the pc. The current behaviour ofc.nop
excludes these from its encoding which causes them to fail to dissemble. The correct behaviour is to either include the hints into the encoding of the base instruction, or separate them out into a different hint instruction. As they have been included in the base instruction in other places the same has been done for thec.nop
instruction.