Merge branch 'main' into fix/webpack-notify-cli-on-errors

NativeScript · Mar 28, 2023 · 79487a6 · 79487a6
2 parents 4e5c8f9 + 671603a
commit 79487a6
Show file tree

Hide file tree

Showing 178 changed files with 3,420 additions and 2,475 deletions.
diff --git a/.eslintrc.json b/.eslintrc.json
@@ -24,7 +24,22 @@
 		{
 			"files": ["*.ts", "*.tsx"],
 			"extends": ["eslint:recommended", "plugin:@typescript-eslint/recommended", "prettier", "plugin:@nrwl/nx/typescript"],
-			"rules": {}
+			"rules": {
+				"no-empty": "off",
+				"no-useless-escape": "off",
+				"no-inner-declarations": "off",
+				"no-prototype-builtins": "off",
+				"@typescript-eslint/no-empty-interface": "off",
+				"@typescript-eslint/no-var-requires": "off",
+				"@typescript-eslint/no-empty-function": "off",
+				"@typescript-eslint/ban-ts-comment": "off",
+				"@typescript-eslint/ban-types": "off",
+				"@typescript-eslint/no-unused-vars": "off",
+				"@typescript-eslint/no-explicit-any": "off",
+				"@typescript-eslint/no-this-alias": "warn",
+				"@typescript-eslint/no-namespace": "off",
+				"@typescript-eslint/no-inferrable-types": "off"
+			}
 		},
 		{
 			"files": ["*.js", "*.jsx"],

diff --git a/.github/workflows/apps_automated.yml b/.github/workflows/apps_automated.yml
@@ -29,7 +29,7 @@ jobs:
           java-version: '11'
 
       - name: Install Python
-        uses: actions/setup-python@v1
+        uses: actions/setup-python@v4
 
       - name: Install NativeScript
         run: |
@@ -53,7 +53,7 @@ jobs:
 
       - name: Start iOS Simulator
         if: ${{ always() && !cancelled() }} # run iOS tests even if Android tests failed
-        uses: futureware-tech/simulator-action@v1
+        uses: futureware-tech/simulator-action@v2
         with:
           model: 'iPhone 13 Pro Max'
           os_version: '>=15.0'

diff --git a/.vscode/settings.json b/.vscode/settings.json
@@ -6,6 +6,5 @@
         "**/platforms": true,
         "**/*.js": true,
         "**/*.js.map": true
-    },
-    "tslint.configFile": "./build/tslint.json"
+    }
 }
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,76 @@
+## [8.4.7](https://github.com/NativeScript/NativeScript/compare/5.0.13-webpack...8.4.7) (2023-01-23)
+
+
+### Bug Fixes
+
+* **core:** allow CoreTypes declarations to be auto generated ([#10183](https://github.com/NativeScript/NativeScript/issues/10183)) ([9f76fea](https://github.com/NativeScript/NativeScript/commit/9f76fea06e02a3f4de4fa69cbc73eb9aa0c8db47))
+* **ios:** race condition when setting preferredContentSize on view controller ([#10179](https://github.com/NativeScript/NativeScript/issues/10179)) ([ed14e24](https://github.com/NativeScript/NativeScript/commit/ed14e242831dc28398bce62a78c7ee8d71f50bed))
+* **ios:** race conditions with nativeView ([#10182](https://github.com/NativeScript/NativeScript/issues/10182)) ([c42c3c5](https://github.com/NativeScript/NativeScript/commit/c42c3c5f2609afaa96bf874c427f0702f8cd5daa))
+
+
+
+## [8.4.6](https://github.com/NativeScript/NativeScript/compare/8.4.5-core...8.4.6-core) (2023-01-19)
+
+
+### Bug Fixes
+
+* **core:** ScrollView event wiring sequencing improvement ([#10178](https://github.com/NativeScript/NativeScript/issues/10178)) ([75821ea](https://github.com/NativeScript/NativeScript/commit/75821ead07dc69ffeb82c6bd6d6992095ee4fed1))
+
+
+
+## [8.4.5](https://github.com/NativeScript/NativeScript/compare/8.4.4-core...8.4.5-core) (2023-01-16)
+
+
+### Bug Fixes
+
+* **core:** improve loaded/unloaded handling ([18b911e](https://github.com/NativeScript/NativeScript/commit/18b911ed84173928d1d0cfc91be605e046a7e3d1))
+* **core:** improve loaded/unloaded handling to be stable and consistent ([#10170](https://github.com/NativeScript/NativeScript/issues/10170)) ([c9e29aa](https://github.com/NativeScript/NativeScript/commit/c9e29aa9af8b4b82cd259f8402fa11af4640f1b4))
+* **ios:** embedder usage of window ([#10167](https://github.com/NativeScript/NativeScript/issues/10167)) ([a69a9d6](https://github.com/NativeScript/NativeScript/commit/a69a9d6921bd1df11b29c9b697bfb847a3885458))
+
+
+
+## [8.4.4](https://github.com/NativeScript/NativeScript/compare/8.4.3-core...8.4.4-core) (2023-01-09)
+
+
+### Bug Fixes
+
+* **android:** openUrl ([#10161](https://github.com/NativeScript/NativeScript/issues/10161)) ([451c3cf](https://github.com/NativeScript/NativeScript/commit/451c3cfe43a90be705bb6cc7abb220e674d1d906))
+* **mac:** utils for mac catalyst ([#10157](https://github.com/NativeScript/NativeScript/issues/10157)) ([5b6e4d6](https://github.com/NativeScript/NativeScript/commit/5b6e4d68986f22219c41f434f2bf51e714e485a5))
+
+
+### Features
+
+* **core:** new autoFillTypes for newUsername, newPassword and oneTimeCode ([#10159](https://github.com/NativeScript/NativeScript/issues/10159)) ([bff35e5](https://github.com/NativeScript/NativeScript/commit/bff35e5163d126d44ae3b2828ed96dbdc6c2e6ef))
+
+
+
+## [8.4.3](https://github.com/NativeScript/NativeScript/compare/8.4.2-core...8.4.3-core) (2023-01-04)
+
+
+### Bug Fixes
+
+* **android:** WebView url and event handling ([#10147](https://github.com/NativeScript/NativeScript/issues/10147)) ([#10148](https://github.com/NativeScript/NativeScript/issues/10148)) ([8444087](https://github.com/NativeScript/NativeScript/commit/84440876feb8a0b4bc5bc2309dc7a9315d1f91ef))
+* **ios:** prevent layout in viewSafeAreaInsetsDidChange until first viewDidLayoutSubviews ([#10151](https://github.com/NativeScript/NativeScript/issues/10151)) ([760bbd0](https://github.com/NativeScript/NativeScript/commit/760bbd06faf3acb7e0694acaf1ad3e029f1cd278))
+* **ios:** prevent transitionCoordinator usage during modal presentation ([#10153](https://github.com/NativeScript/NativeScript/issues/10153)) ([d138ac0](https://github.com/NativeScript/NativeScript/commit/d138ac000df2e2dfc890db992c39a4429e6ed8dc))
+* **ios:** TextField keyboard handling with emoji, autofill, and shortcuts ([#10154](https://github.com/NativeScript/NativeScript/issues/10154)) ([00944bb](https://github.com/NativeScript/NativeScript/commit/00944bb1b5b6f4cc8084cf7cde3db6448e28e0bd))
+
+
+
+## [8.4.2](https://github.com/NativeScript/NativeScript/compare/8.4.1-core...8.4.2-core) (2022-12-29)
+
+
+### Bug Fixes
+
+* **android:** backwards compat Java cast Float to Long for ApplicationSettings.getNumber ([#10140](https://github.com/NativeScript/NativeScript/issues/10140)) ([7c1590a](https://github.com/NativeScript/NativeScript/commit/7c1590abff0127fd1e5254648cdd1d8c7ab49869))
+* **core:** update metadata filtering for IOS 16 ([#10133](https://github.com/NativeScript/NativeScript/issues/10133)) ([c461f1b](https://github.com/NativeScript/NativeScript/commit/c461f1bb551a69e721548fa5ae6ca2c7601d0b87))
+* **ios:** box shadow border radius ([#10142](https://github.com/NativeScript/NativeScript/issues/10142)) ([6948f7c](https://github.com/NativeScript/NativeScript/commit/6948f7c03265ebf9b92a7d5f69bfbb4743ce449b))
+* **ios:** navigatingTo event handling ([#10120](https://github.com/NativeScript/NativeScript/issues/10120)) ([a4f28b8](https://github.com/NativeScript/NativeScript/commit/a4f28b831785c8cf6ba76c170fcd7a5628b12c35))
+* **ios:** reset additional insets if they're zero ([#10134](https://github.com/NativeScript/NativeScript/issues/10134)) ([8b7d5ab](https://github.com/NativeScript/NativeScript/commit/8b7d5ab5fc34fa7785b7801ca5de60e69bbf7392))
+* **listview:** delegate handling removed from unloaded ([#10138](https://github.com/NativeScript/NativeScript/issues/10138)) ([04c3d9a](https://github.com/NativeScript/NativeScript/commit/04c3d9a9795898386f26656018bc05cf697d09e2))
+* **utils:** ios to filter out null values  ([#10117](https://github.com/NativeScript/NativeScript/issues/10117)) ([4723114](https://github.com/NativeScript/NativeScript/commit/47231145acb851552d7990e5a75b66dd6d06fee8))
+
+
+
 ## [8.4.1](https://github.com/NativeScript/NativeScript/compare/8.4.0-core...8.4.1-core) (2022-11-30)
 
 ### Bug Fixes

diff --git a/README.md b/README.md
@@ -7,13 +7,13 @@
 <p>
 
   [![Automated Tests Passing](https://github.com/NativeScript/NativeScript/actions/workflows/apps_automated.yml/badge.svg)](https://github.com/NativeScript/NativeScript/actions/workflows/apps_automated.yml)
-  [![License](https://img.shields.io/badge/License-MIT-blue.svg)](https://github.com/NativeScript/NativeScript/blob/master/LICENSE)
+  [![License](https://img.shields.io/badge/License-MIT-blue.svg)](https://github.com/NativeScript/NativeScript/blob/main/LICENSE)
   [![NPM Version](https://badge.fury.io/js/%40nativescript%2Fcore.svg)](https://www.npmjs.com/@nativescript/core)
   [![Discord](https://badgen.net/badge/icon/discord?icon=discord&label)](https://nativescript.org/discord)
 
 </p>
 
-[NativeScript](http://www.nativescript.org) empowers you to access native APIs from JavaScript directly. Currently iOS and Android runtimes are provided for rich mobile development across a variety of diverse use cases. 
+[NativeScript](http://www.nativescript.org) empowers you to access native APIs from JavaScript directly. Currently iOS and Android runtimes are provided for rich mobile development across a variety of diverse use cases.
 
 ## Contribute
 
@@ -32,24 +32,24 @@ $ npm run setup
 $ npm start
 ```
 
-We love you and your pull requests 🤗. Please follow our [contributing guide](https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md) and see [our code of governance](https://github.com/NativeScript/management/blob/master/nativescript-governance.md) to become as involved as you want to be.
+We love you and your pull requests 🤗. Please follow our [contributing guide](https://github.com/NativeScript/NativeScript/blob/main/tools/notes/CONTRIBUTING.md) and see [our code of governance](https://github.com/NativeScript/management/blob/master/nativescript-governance.md) to become as involved as you want to be.
 
 ## @nativescript/*
 
-* [@nativescript/core](https://github.com/NativeScript/NativeScript/tree/master/packages/core)
-  * Core iOS/Android for NativeScript
+* [@nativescript/core](https://github.com/NativeScript/NativeScript/tree/main/packages/core)
+  * Core iOS/Android for NativeScript.
 * [@nativescript/types](https://www.npmjs.com/package/@nativescript/types)
   * Types for both iOS/Android below wrapped up as a convenience. *Most commonly used.*
-* [@nativescript/types-ios](https://github.com/NativeScript/NativeScript/tree/master/packages/types-ios)
-  * Types for iOS
-* [@nativescript/types-android](https://github.com/NativeScript/NativeScript/tree/master/packages/types-android)
-  * Types for Android
-* [@nativescript/types-minimal](https://github.com/NativeScript/NativeScript/tree/master/packages/types-minimal)
+* [@nativescript/types-ios](https://github.com/NativeScript/NativeScript/tree/main/packages/types-ios)
+  * Types for iOS.
+* [@nativescript/types-android](https://github.com/NativeScript/NativeScript/tree/main/packages/types-android)
+  * Types for Android.
+* [@nativescript/types-minimal](https://github.com/NativeScript/NativeScript/tree/main/packages/types-minimal)
   * A very minimal set of types for only the latest Android and iOS sdks. Most commonly used to optimize Web-based IDE's which auto load all type declarations from node_modules.
-* [@nativescript/ui-mobile-base](https://github.com/NativeScript/NativeScript/tree/master/packages/ui-mobile-base)
-  * UI mobile base native classes used by core
-* [@nativescript/webpack](https://github.com/NativeScript/NativeScript/tree/master/packages/webpack)
-  * Webpack build utilities and configs used by NativeScript apps
+* [@nativescript/ui-mobile-base](https://github.com/NativeScript/NativeScript/tree/main/packages/ui-mobile-base)
+  * UI mobile base native classes used by core.
+* [@nativescript/webpack](https://github.com/NativeScript/NativeScript/tree/main/packages/webpack5)
+  * Webpack build utilities and configs used by NativeScript apps.
 
 ## Quick Links
 
@@ -78,7 +78,15 @@ Outside the source centralized in this repo, NativeScript consists of a few othe
 	- This repo contains the NativeScript command-line interface, which lets you create, build, and run apps using NativeScript. The CLI is written in TypeScript.
 - **[Docs](//github.com/NativeScript/docs-new)**
 	- This repo contains NativeScript documentation, which is available at <http://docs.nativescript.org/>. The docs are written in Markdown.
-- **[Official Plugins](https://github.com/NativeScript/plugins)
-  - This repo contains a [plugin workspace](https://docs.nativescript.org/plugins/plugin-workspace-guide.html) the TSC (Technical Steering Committee) maintains offering several often useful plugins.
+- **[Plugins](https://github.com/NativeScript/plugins)**
+  - This repo contains a [plugin workspace](https://docs.nativescript.org/plugins/plugin-workspace-guide.html) with several often useful plugins.
+- **[Firebase](https://github.com/NativeScript/firebase)**
+  - Modular Firebase 🔥 implementation for iOS & Android.
+- **[ML Kit](https://github.com/NativeScript/mlkit)**
+  - Google's [ML Kit SDKs for iOS and Android](https://developers.google.com/ml-kit).
+- **[Payments](https://github.com/NativeScript/payments)**
+  - In-App Purchase, Subscriptions, Google Pay and Apple Pay.
+- **[Artwork](https://github.com/NativeScript/artwork)**
+  - Want to use our logo or colors? This repo contains ready to use media material.
 
 <h3 align="center">Made with ❤️</h3>
diff --git a/apps/automated/.npmrc b/apps/automated/.npmrc
@@ -1 +1,6 @@
 legacy-peer-deps=true
+
+# npm 9+ this defaults to `true` meaning `file:` dependencies are packed and then installed
+# but since we want to link the source files in this case, we disable this behavior and
+# opt to link the dependency as-is instead. (eg. @nativescript/core)
+install-links=false
diff --git a/apps/automated/package.json b/apps/automated/package.json
@@ -11,10 +11,10 @@
     "nativescript-theme-core": "file:../../node_modules/nativescript-theme-core"
   },
   "devDependencies": {
-    "@nativescript/android": "~8.3.0",
-    "@nativescript/ios": "~8.3.0",
+    "@nativescript/android": "~8.4.0",
+    "@nativescript/ios": "~8.4.0",
     "@nativescript/webpack": "file:../../dist/packages/nativescript-webpack.tgz",
-    "typescript": "4.8.4"
+    "typescript": "~4.9.5"
   },
   "gitHead": "c06800e52ee1a184ea2dffd12a6702aaa43be4e3",
   "readme": "NativeScript Application"

diff --git a/apps/automated/src/application/application-tests-common.ts b/apps/automated/src/application/application-tests-common.ts
@@ -19,7 +19,7 @@ export function testInitialized() {
 
 export function testDisplayedEvent() {
 	// global.isDisplayedEventFired flag is set in app.ts application.displayedEvent handler
-	TKUnit.assert((<any>global).isDisplayedEventFired, 'application.displayedEvent not fired');
+	TKUnit.assert(global.isDisplayedEventFired, 'application.displayedEvent not fired');
 }
 
 export function testOrientation() {

diff --git a/apps/automated/src/fetch/fetch-tests.ts b/apps/automated/src/fetch/fetch-tests.ts
@@ -8,7 +8,7 @@ export var test_fetch_defined = function () {
 
 export var test_fetch = function (done: (err: Error, res?: string) => void) {
 	// >> fetch-response
-	fetch('https://httpbin.org/get')
+	fetch('https://http-echo.nativescript.org/get')
 		.then(function (r) {
 			// Argument (r) is Response!
 			// >> (hide)
@@ -22,7 +22,7 @@ export var test_fetch = function (done: (err: Error, res?: string) => void) {
 
 export var test_fetch_text = function (done: (err: Error, res?: string) => void) {
 	// >> fetch-string
-	fetch('https://httpbin.org/get')
+	fetch('https://http-echo.nativescript.org/get')
 		.then((response) => response.text())
 		.then(function (r) {
 			// Argument (r) is string!
@@ -37,7 +37,7 @@ export var test_fetch_text = function (done: (err: Error, res?: string) => void)
 
 export var test_fetch_json = function (done: (err: Error, res?: string) => void) {
 	// >> fetch-json
-	fetch('https://httpbin.org/get')
+	fetch('https://http-echo.nativescript.org/get')
 		.then((response) => response.json())
 		.then(function (r) {
 			// Argument (r) is JSON object!
@@ -52,7 +52,7 @@ export var test_fetch_json = function (done: (err: Error, res?: string) => void)
 
 export var test_fetch_formData = function (done: (err: Error, res?: string) => void) {
 	// >> fetch-formdata
-	fetch('https://httpbin.org/get')
+	fetch('https://http-echo.nativescript.org/get')
 		.then((response) => response.formData())
 		.then(function (r) {
 			// Argument (r) is FormData object!
@@ -67,7 +67,7 @@ export var test_fetch_formData = function (done: (err: Error, res?: string) => v
 
 export var test_fetch_blob = function (done: (err: Error, res?: string) => void) {
 	// >> fetch-blob
-	fetch('https://httpbin.org/get')
+	fetch('https://http-echo.nativescript.org/get')
 		.then((response) => response.blob())
 		.then(function (r) {
 			// Argument (r) is Blob object!
@@ -82,7 +82,7 @@ export var test_fetch_blob = function (done: (err: Error, res?: string) => void)
 
 export var test_fetch_arraybuffer = function (done: (err: Error, res?: string) => void) {
 	// >> fetch-arraybuffer
-	fetch('https://httpbin.org/get')
+	fetch('https://http-echo.nativescript.org/get')
 		.then((response) => response.arrayBuffer())
 		.then(function (r) {
 			// Argument (r) is ArrayBuffer object!
@@ -101,7 +101,7 @@ export var test_fetch_fail_invalid_url = function (done) {
 		return completed;
 	};
 
-	fetch('hgfttp://httpbin.org/get')
+	fetch('hgfttp://http-echo.nativescript.org/get')
 		.catch(function (e) {
 			completed = true;
 			done(null);
@@ -111,15 +111,15 @@ export var test_fetch_fail_invalid_url = function (done) {
 
 // Note: fetch is unable to do url validation
 // export var test_fetch_invalid_url_fail_message = function (done) {
-//     fetch("hgfttp://httpbin.org/get").catch(function (e: TypeError) {
+//     fetch("hgfttp://http-echo.nativescript.org/get").catch(function (e: TypeError) {
 //         TKUnit.assert(e.message.match(/Network request failed:.{2,}/), "Failure message should contain details on the failure. Actual message was: " + e.message);
 //         done(null);
 //     }).catch(failOnError(done));
 // };
 
 export var test_fetch_response_status = function (done) {
 	// >> fetch-status-response
-	fetch('https://httpbin.org/get')
+	fetch('https://http-echo.nativescript.org/get')
 		.then(function (response) {
 			// Argument (response) is Response!
 			var statusCode = response.status;
@@ -134,7 +134,7 @@ export var test_fetch_response_status = function (done) {
 
 export var test_fetch_response_headers = function (done) {
 	// >> fetch-headers-response
-	fetch('https://httpbin.org/get')
+	fetch('https://http-echo.nativescript.org/get')
 		.then(function (response) {
 			// Argument (response) is Response!
 			// var all = response.headers.getAll();
@@ -148,7 +148,7 @@ export var test_fetch_response_headers = function (done) {
 };
 
 export var test_fetch_headers_sent = function (done) {
-	fetch('https://httpbin.org/get', {
+	fetch('https://http-echo.nativescript.org/get', {
 		method: 'GET',
 		headers: new Headers({ 'Content-Type': 'application/json' }),
 	})
@@ -165,7 +165,7 @@ export var test_fetch_post_form_data = function (done) {
 	data.append('MyVariableOne', 'ValueOne');
 	data.append('MyVariableTwo', 'ValueTwo');
 
-	fetch('https://httpbin.org/post', {
+	fetch('https://http-echo.nativescript.org/post', {
 		method: 'POST',
 		headers: new Headers({ 'Content-Type': 'application/x-www-form-urlencoded' }),
 		body: data,
@@ -182,7 +182,7 @@ export var test_fetch_post_form_data = function (done) {
 
 export var test_fetch_post_json = function (done) {
 	// >> fetch-post-json
-	fetch('https://httpbin.org/post', {
+	fetch('https://http-echo.nativescript.org/post', {
 		method: 'POST',
 		headers: new Headers({ 'Content-Type': 'application/json' }),
 		body: JSON.stringify({ MyVariableOne: 'ValueOne', MyVariableTwo: 'ValueTwo' }),

diff --git a/apps/automated/src/globals/globals-tests.ts b/apps/automated/src/globals/globals-tests.ts
@@ -6,8 +6,8 @@ export function test_global_system_import() {
 	TKUnit.assert(System, 'System not defined');
 	TKUnit.assert(typeof System.import === 'function', 'System.import not a function');
 
-	TKUnit.assert((<any>global).System, 'global.System not defined');
-	TKUnit.assert(typeof (<any>global).System.import === 'function', 'global.System.import not a function');
+	TKUnit.assert(global.System, 'global.System not defined');
+	TKUnit.assert(typeof global.System.import === 'function', 'global.System.import not a function');
 }
 
 export function test_global_zonedCallback() {

diff --git a/apps/automated/src/http/http-string-worker.ts b/apps/automated/src/http/http-string-worker.ts
@@ -5,7 +5,7 @@ postMessage('stub');
 //
 // import { getString } from '@nativescript/core/http';
 //
-// getString('https://httpbin.org/get').then(
+// getString('https://http-echo.nativescript.org/get').then(
 // 	function (r) {
 // 		postMessage(r);
 // 	},