feat(android): Implementing 'onBackPressed' for frame-root (#8634)

Useful for meddling with tab-navigated apps. Co-authored-by: Dimitris - Rafail Katsampas <katsampasdr@gmail.com>
NativeScript · Jun 13, 2020 · c73952f · c73952f
1 parent 3198f92
commit c73952f
Showing 1 changed file with 11 additions and 13 deletions.
diff --git a/nativescript-core/ui/frame/frame.android.ts b/nativescript-core/ui/frame/frame.android.ts
@@ -1221,20 +1221,18 @@ class ActivityCallbacksImplementation implements AndroidActivityCallbacks {
 
         const view = this._rootView;
         let callSuper = false;
-        if (view instanceof Frame) {
-            callSuper = !FrameBase.goBack();
-        } else {
-            const viewArgs = <application.AndroidActivityBackPressedEventData>{
-                eventName: "activityBackPressed",
-                object: view,
-                activity: activity,
-                cancel: false,
-            };
-            view.notify(viewArgs);
+
+        const viewArgs = <application.AndroidActivityBackPressedEventData>{
+            eventName: "activityBackPressed",
+            object: view,
+            activity: activity,
+            cancel: false,
+        };
+        view.notify(viewArgs);
 
-            if (!viewArgs.cancel && !view.onBackPressed()) {
-                callSuper = true;
-            }
+        // In the case of Frame, use this callback only if it was overridden, since the original will cause navigation issues
+        if (!viewArgs.cancel && (view.onBackPressed === Frame.prototype.onBackPressed || !view.onBackPressed())) {
+            callSuper = view instanceof Frame ? !FrameBase.goBack() : true;
         }
 
         if (callSuper) {