Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): CSS style not working properly in Android modal pages #10070

Merged
merged 2 commits into from
Nov 4, 2022

Conversation

dgmachado
Copy link
Contributor

@dgmachado dgmachado commented Oct 28, 2022

PR Checklist

What is the current behavior?

When app is set with force light mode settings, the styling on modal page is not working if having .ns-light identifier.

Please find the sample app and screen recording attached. (run npm i first)

Steps to reproduce:

1) Tap on 'MODAL' actionbar item to show a modal page.
2) Notice the 'Testing: 1' label on the modal page is in grey color even though on app.android.css, the Label type is styled as red color. 
modal_frame_cssclass_issue.mov

What is the new behavior?

Fixes/Implements/Closes #[Issue Number].

The css is being applied properly.

Sample app:
testPopoverModal.zip

@cla-bot cla-bot bot added the cla: yes label Oct 28, 2022
@farfromrefug
Copy link
Collaborator

@dgmachado awesome fix!!! Might be fixing another issue of mine

@NathanWalker NathanWalker added this to the 8.4 milestone Nov 4, 2022
@NathanWalker NathanWalker merged commit 608d3b9 into NativeScript:main Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants