Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Android layerType should not be changed if there is no need #1899

Closed
hshristov opened this issue Apr 6, 2016 · 1 comment · Fixed by #2211
Closed

Android layerType should not be changed if there is no need #1899

hshristov opened this issue Apr 6, 2016 · 1 comment · Fixed by #2211
Labels
bug done os: android severity: medium
Milestone
2.1

Comments

@hshristov
Copy link
Contributor

Don't change android layer type If possible because it cause different type of issues on different devices. If change is mandatory first cache current layer type using nativeView.getLayerType() so a reset will return it to its default value - not like now setting it always to software_layer.

Check #1874 for one such problem.
@hshristov hshristov mentioned this issue Apr 6, 2016
Closed
@enchev enchev mentioned this issue Apr 12, 2016
Closed
@bradmartin bradmartin mentioned this issue Apr 19, 2016
Closed
@hshristov hshristov added this to the 2.1 milestone May 19, 2016
@hamorphis hamorphis self-assigned this May 26, 2016
hamorphis added a commit that referenced this issue May 30, 2016
@hamorphis
Fixed: Android layerType should not be changed if there is no need
547822e 
Resolves #1899
@hamorphis hamorphis mentioned this issue May 30, 2016
Merged
hamorphis added a commit that referenced this issue May 30, 2016
@hamorphis
Fixed: Android layerType should not be changed if there is no need
e2f1e27 
Resolves #1899
@hshristov hshristov added ready for test TSC needs to test this and confirm against live production apps and automated test suites and removed backlog labels Jun 6, 2016
@hamorphis hamorphis added done and removed ready for test TSC needs to test this and confirm against live production apps and automated test suites labels Jun 15, 2016
@lock
Copy link

lock bot commented Aug 29, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot unassigned hamorphis Aug 29, 2019
@lock lock bot locked and limited conversation to collaborators Aug 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug done os: android severity: medium
Projects
None yet
Milestone
2.1
Development

Successfully merging a pull request may close this issue.

Fixed: Android layerType should not be changed if there is no need NativeScript/NativeScript
2 participants
@hamorphis @hshristov