Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS border-width causes text to overflow TextView #2789

Closed
3rror404 opened this issue Sep 22, 2016 · 4 comments · Fixed by #2801
Closed

CSS border-width causes text to overflow TextView #2789

3rror404 opened this issue Sep 22, 2016 · 4 comments · Fixed by #2801
Assignees
Milestone

Comments

@3rror404
Copy link

Setting a border-width CSS value on a TextView cause the text to overflow the bounds of the element when using tns-core-modules 2.4.0-2016-09-21-4189. This was working correctly in 2.3.0

ns-textview-overflow

Reproducable using the Hello World template and the code below.

XML:

<Page xmlns="http://schemas.nativescript.org/tns.xsd">
  <TextView />
</Page>

CSS:

TextView {
    border-width: 1;
}
┌──────────────────┬───────────────────────┬────────────────┬───────────────┐
│ Component        │ Current version       │ Latest version │ Information   │
│ nativescript     │ 2.3.0                 │ 2.3.0          │ Up to date    │
│ tns-core-modules │ 2.4.0-2016-09-21-4189 │ 2.3.0          │ Up to date    │
│ tns-android      │                       │ 2.3.0          │ Not installed │
│ tns-ios          │ 2.3.0                 │ 2.3.0          │ Up to date    │
└──────────────────┴───────────────────────┴────────────────┴───────────────┘
@hamorphis
Copy link
Contributor

@3rror404 When I try this the TextView occupies the entire page and its border is drawn correctly. Are you sure you are not omitting part of the code. Maybe some dimensions set on the TextView or the TextView is in some kind of layout? Can you share the complete code to reproduce this? Thanks.

@hamorphis
Copy link
Contributor

@3rror404 Never mind. I reproduced it by setting fix height. The TextView draws its border correctly but does not clip what is outside its client area.

@hamorphis
Copy link
Contributor

@3rror404 Just for the record, I tried with 2.3.0 and the result is exactly the same. Nevertheless, I still need to fix this. Stay tuned...

@lock
Copy link

lock bot commented Aug 29, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Aug 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants