Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSS clip-path rect() shape function implemented incorrectly #3060

Closed
hamorphis opened this issue Nov 10, 2016 · 2 comments · Fixed by #3061
Closed

CSS clip-path rect() shape function implemented incorrectly #3060

hamorphis opened this issue Nov 10, 2016 · 2 comments · Fixed by #3061
Assignees
@hamorphis
Labels
breaking-change bug done severity: high
Projects
2.5
Milestone
2.5.0

Comments

@hamorphis
Copy link
Contributor

We were reading the four values as rect(top, left, bottom, right), but according to w3c they should be rect(top, right, bottom, left).

http://www.w3schools.com/cssreF/pr_pos_clip.asp
@hamorphis hamorphis added this to the 2.5.0 milestone Nov 10, 2016
@hamorphis hamorphis self-assigned this Nov 10, 2016
hamorphis added a commit to NativeScript/tns-core-modules-widgets that referenced this issue Nov 10, 2016
@hamorphis
Add inset CSS clip-path support
e00fa2a 
Resolves NativeScript/NativeScript#2693
Resolves NativeScript/NativeScript#3060
@hamorphis hamorphis mentioned this issue Nov 10, 2016
Merged
@hamorphis
Copy link
Contributor Author

Furthermore, we were using CGRectMake(left, top, right, bottom) incorrectly. The method expects width and height, so it should be CGRectMake(left, top, right - left, bottom - top)

@hamorphis hamorphis mentioned this issue Nov 10, 2016
Merged
@hamorphis hamorphis changed the title CSS clip-path rect() shape function is implemented incorrectly CSS clip-path rect() shape function implemented incorrectly Nov 11, 2016
@lock
Copy link

lock bot commented Aug 29, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Aug 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@hamorphis hamorphis

Labels
breaking-change bug done severity: high
Projects
No open projects
2.5
Done
Milestone
2.5.0
Development

Successfully merging a pull request may close this issue.

Add inset CSS clip-path support NativeScript/NativeScript
1 participant
@hamorphis