Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Android platform.screen.mainScreen props are not invalidated after orientation change #3270

Closed
hamorphis opened this issue Dec 9, 2016 · 1 comment · Fixed by #3279
Closed

Android platform.screen.mainScreen props are not invalidated after orientation change #3270

hamorphis opened this issue Dec 9, 2016 · 1 comment · Fixed by #3279
Assignees
@hamorphis
Labels
bug in progress os: android severity: high
Milestone
2.5.0

Comments

@hamorphis
Copy link
Contributor

platform.screen.mainScreen.widthDIPs and platform.screen.mainScreen.heightDIPs are read only once when the module is loaded and then cached forever. When the orientation of the device changes they need to be invalidated so the correct ones could be read again.
@hamorphis hamorphis added this to the 2.5.0 milestone Dec 9, 2016
@hamorphis hamorphis self-assigned this Dec 9, 2016
hamorphis added a commit that referenced this issue Dec 12, 2016
@hamorphis
Fix: Android platform.screen.mainScreen props are not invalidated aft…
8587c79 
…er orientation change

Resolves #3270
@hamorphis hamorphis mentioned this issue Dec 12, 2016
Merged
hamorphis added a commit that referenced this issue Dec 12, 2016
@hamorphis
Fix: Android platform.screen.mainScreen props are not invalidated aft…
3e461cd 
…er orientation change

Resolves #3270
hamorphis added a commit that referenced this issue Jan 3, 2017
@hamorphis
Fix: Android platform.screen.mainScreen props are not invalidated aft…
e6d6479 
…er orientation change

Resolves #3270
@hamorphis hamorphis mentioned this issue Jan 3, 2017
Merged
@lock
Copy link

lock bot commented Aug 29, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Aug 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@hamorphis hamorphis

Labels
bug in progress os: android severity: high
Projects
None yet
Milestone
2.5.0
Development

Successfully merging a pull request may close this issue.

Fix: Android platform.screen.mainScreen props are not invalidated aft… NativeScript/NativeScript
1 participant
@hamorphis