Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: Core Module change causing style to break #4728

Closed
bradmartin opened this issue Aug 22, 2017 · 9 comments
Closed

Question: Core Module change causing style to break #4728

bradmartin opened this issue Aug 22, 2017 · 9 comments
Assignees
Labels
bug done os: android ready for test TSC needs to test this and confirm against live production apps and automated test suites
Milestone

Comments

@bradmartin
Copy link
Contributor

Please, provide the details below:

I normally wouldn't open an issue for this type of bug without investigating but too many people have hit the same issue and I don't recall any changes in the plugins in quite some time and I haven't had time to debug the issue. The issue is on both cardview and floatingactionbutton plugin repos have been opened with the same issue recently.

nstudio/nativescript-cardview#64
nstudio/nativescript-floatingactionbutton#57

Which platform(s) does your issue occur on?

Android for sure

Please provide the following version numbers that your issue occurs with:

See issue

Please tell us how to recreate the issue in as much detail as possible.

Run latest core modules with either the cardview or fab plugin as described in the issue on the repos. Someone has reported a revert in the core-modules fixed the issue and then when updating to the latest it breaks again.

Is there code involved? If so, please share the minimal amount of code needed to recreate the problem.

Demo code on repos should be sufficient.

@tsonevn
Copy link
Contributor

tsonevn commented Aug 23, 2017

Hi @bradmartin,
Thank you for reporting this issue.
We reviewed the described scenario and indeed there is an issue with getting drawable from the native view, which in some cases is a null object.
We will investigate further how to resolve this problem and will provide a fix inside the tns-core-modules.
Regards,
@tsonevn

@hshristov
Copy link
Contributor

Hi @bradmartin

Thanks for reporting this. It is fixed in the master branch with this PR: #4742 and will be live in 3.2

@hshristov hshristov added this to the 3.2 milestone Aug 29, 2017
@hshristov hshristov added the done label Aug 29, 2017
@hshristov hshristov self-assigned this Aug 29, 2017
@tsonevn tsonevn added the ready for test TSC needs to test this and confirm against live production apps and automated test suites label Aug 29, 2017
@SP1966
Copy link

SP1966 commented Sep 11, 2017

After updating this issue is still unresolved in both of the following plugins:

nstudio/nativescript-floatingactionbutton#57
nstudio/nativescript-cardview#64

@jafsparrow
Copy link

Hi All,

Any update on this? anybody figured out the reason and way to fix it.?

@bradmartin
Copy link
Contributor Author

@hshristov - I believe an issue might still be present on Android 6 per this comment nstudio/nativescript-floatingactionbutton#57 (comment)

@jafsparrow
Copy link

Thanks Brad, I will try this on 7 then..!
But there's gotta be a reason for this..! I'm facing same kind of issue with FAB and CardView.

hshristov pushed a commit that referenced this issue Oct 18, 2017
@hshristov
Copy link
Contributor

@bradmartin @jafsparrow @SP1966
Addition to the original fix because of bug in Android 6.0 API 23
#4959

hshristov pushed a commit that referenced this issue Oct 18, 2017
@jafsparrow
Copy link

Thank you @hshristov.

for FAB and CardView
I think explicitly giving the color property is solving the issue (can be used a hack fix).

I was also testing the dropdown plugin which is also breaking if some properties are not given in css (specifying the properties in css fixes the issue).

thanks guys for your helps..

@lock
Copy link

lock bot commented Aug 27, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Aug 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug done os: android ready for test TSC needs to test this and confirm against live production apps and automated test suites
Projects
None yet
Development

No branches or pull requests

5 participants