Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android Keyboard Next Doesn't Move Focus To Next TextField #5033

Closed
jevenson opened this issue Nov 3, 2017 · 4 comments · Fixed by #5047
Closed

Android Keyboard Next Doesn't Move Focus To Next TextField #5033

jevenson opened this issue Nov 3, 2017 · 4 comments · Fixed by #5047
Assignees

Comments

@jevenson
Copy link

jevenson commented Nov 3, 2017

Did you verify this is a real problem by searching Stack Overflow and the other open issues in this repo?

Yes

Tell us about the problem

On Android, after updating to tns-core-modules v3.3.0, I found that when pressing the next button on the keyboard, the focus does not get moved to the next input on the screen.

Which platform(s) does your issue occur on?

Android

Please provide the following version numbers that your issue occurs with:

  • CLI: 3.3.0
  • Cross-platform modules: 3.3.0
  • Runtime(s): 3.2.0 or 3.3.0

Please tell us how to recreate the issue in as much detail as possible.

  1. Have multiple TextFields on a page
  2. Tap in first TextField
  3. Press Next Action on Android Keyboard
  4. Observe focus does not move to next TextField

Is there code involved? If so, please share the minimal amount of code needed to recreate the problem.

There are two {N} apps in the repository. The one called ThreeDotTwo is on version 3.2.0 of tns-core-modules and the issue does not exist. The one called ThreeDotThree is on version 3.3.0 and has the next button issue.
https://github.com/jevenson/NativeScript-Android-Keyboard

@tsonevn
Copy link
Contributor

tsonevn commented Nov 6, 2017

Hi @jevenson,
Thank you for the sample projects.
I tested this scenario on our side and indeed it is a real problem for Android.
For further info, please keep track on the issue.

@tsonevn tsonevn added the bug label Nov 6, 2017
hshristov pushed a commit that referenced this issue Nov 8, 2017
Fixes #5033
When clicking next arrow on the virtual keyboard we were returning true which means we handled the event so the OS doesn't move the focus to the next item. This PR delete the `return true` when the action is `IME_ACTION_NEXT` so that next focusable item is automatically focued
@ghost ghost assigned hshristov Nov 8, 2017
@ghost ghost added the in progress label Nov 8, 2017
hshristov pushed a commit that referenced this issue Nov 10, 2017
* Click next moves the focus to next focusable textfield

Fixes #5033
When clicking next arrow on the virtual keyboard we were returning true which means we handled the event so the OS doesn't move the focus to the next item. This PR delete the `return true` when the action is `IME_ACTION_NEXT` so that next focusable item is automatically focued

* Fix IME_ACTION_PREVIOUS to raise returnPress event.
Added unit-test that IME_ACTION_PREVIOUS to raise returnPress event.
Refactored text-field-tests
@JorgeHawkins
Copy link

The issue is still happening on 3.4.3. Focus between text fields is not changing when tapping "Next".

@tsonevn
Copy link
Contributor

tsonevn commented Mar 12, 2018

Hi @JorgeHawkins,
Can you send us sample project, which could be used for debugging?

@lock
Copy link

lock bot commented Aug 26, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Aug 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants