-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ImageQuality API differ on IOS and Android: Use one scale for both #5474
Comments
@madmas sounds legit - I am marking this issue as a "good first issue" so that anyone interested in becoming a NativeScript contributor can make a PR and implement this one. I am guessing one possible approach would be to change the iOS implementation of Once this is done we could implement this for |
@NickIliev I will like to work on this issue. Any guidance will be really helpful. |
@NickIliev Need some help, I followed the Initial Setup and tried to run the Unit tests but every time I am getting this error:
I am really interested in getting this done, any help will be appreciated. |
Update: I was able to fix the issue. I made the required code changes, I also added few extra unit tests. Most test cases are passing but there is one test case with LABEL module that is falling. Also I have been getting these these errors: I am still trying to figure out how to fix these, google search also didn't yield any useful information. |
Update: I ran the tests on another device and now all the tests are passing. Still getting these errors: |
… both platforms Normalize quality in saveToFile and toBase64String to follow 0-100 scale - standardize implementation on both platforms closes NativeScript#5474
Submitted PR #5517 |
… both platforms Normalize quality in saveToFile and toBase64String to follow 0-100 scale - standardize implementation on both platforms closes NativeScript#5474
…rces update definitions and fix logic of quality in image-sources closes NativeScript#5474
) * feat(ios-image-source): standardize quality scale in image-source for both platforms Normalize quality in saveToFile and toBase64String to follow 0-100 scale - standardize implementation on both platforms closes #5474
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
On IOS, Image-Source expects a number between 0.0 to 1.0 to specify the image quality.
On Android, Image-Source expects a number netween 0 and 100.
It brings up the situation developers have to use a platform-check if the want to get a JPG with 80% quality:
I'd suggest to use one scale for both platforms to have an more consistent API.
What do you think?
The text was updated successfully, but these errors were encountered: