-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(iOS): Safe Area Support #6230
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update `nativescript-dev-webpack` dependencies.
Delete `*-nav-page.*` files reproducing the issue. Update `home-page.xml` with `ScrollView` to reproduce the issue.
Update styles -> `app.css`. Update structure -> `home/home-page.xml`. Add Grid + Wrap examples.
MartoYankov
force-pushed
the
ios-safe-area
branch
from
September 20, 2018 15:35
2d2144f
to
a6a97ab
Compare
…into ios-safe-area
…tended by ListViewBase
vchimev
force-pushed
the
ios-safe-area
branch
from
September 26, 2018 14:40
2ae8cc2
to
d4483f9
Compare
--ignore ios11 groceries_ios testsappng_ios ng_animation_examples_ios cuteness_ios |
vchimev
force-pushed
the
ios-safe-area
branch
from
September 27, 2018 13:15
7b202df
to
d025c0e
Compare
test |
MartoYankov
added
the
docs needed
Additional documentation on this issue/PR is needed
label
Sep 28, 2018
ghost
removed
the
in progress
label
Sep 28, 2018
NickIliev
removed
the
docs needed
Additional documentation on this issue/PR is needed
label
Jan 11, 2019
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
All container components and all content components layout in the safe area.
What is the new behavior?
All container components stretch outside the iOS safe area and have all content components layout in the safe area. This basically means the backgrounds of the container components will be seen to the limits of the screen.
Implements #5746.