Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(iOS): Safe Area Support #6230

Merged
merged 186 commits into from
Sep 28, 2018
Merged

feat(iOS): Safe Area Support #6230

merged 186 commits into from
Sep 28, 2018

Conversation

vchimev
Copy link
Contributor

@vchimev vchimev commented Aug 31, 2018

PR Checklist

What is the current behavior?

All container components and all content components layout in the safe area.

What is the new behavior?

All container components stretch outside the iOS safe area and have all content components layout in the safe area. This basically means the backgrounds of the container components will be seen to the limits of the screen.

Implements #5746.

MartoYankov and others added 30 commits August 28, 2018 18:10
Update `nativescript-dev-webpack` dependencies.
Delete `*-nav-page.*` files reproducing the issue.
Update `home-page.xml` with `ScrollView` to reproduce the issue.
Update styles -> `app.css`.
Update structure -> `home/home-page.xml`.
Add Grid + Wrap examples.
@vchimev
Copy link
Contributor Author

vchimev commented Sep 27, 2018

--ignore ios11 groceries_ios testsappng_ios ng_animation_examples_ios cuteness_ios

@MartoYankov
Copy link
Contributor

test

@MartoYankov MartoYankov added the docs needed Additional documentation on this issue/PR is needed label Sep 28, 2018
@vchimev vchimev merged commit 982acdc into master Sep 28, 2018
@ghost ghost removed the in progress label Sep 28, 2018
@vchimev vchimev deleted the ios-safe-area branch September 28, 2018 15:21
@NickIliev NickIliev removed the docs needed Additional documentation on this issue/PR is needed label Jan 11, 2019
@lock
Copy link

lock bot commented Jan 11, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Jan 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants