fix: xml parsing when input value is reported as object instead of string #7916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…instead of string The [raw-loader](https://github.com/webpack-contrib/raw-loader/blob/6cf76b8947d34fcbe2c11fabc0a995cbf246615f/src/index.js#L18) changed the way they export modules e.g they've already used ES Module export instead of CommonJS. This way, the format of modules inside `bundle.js` or `vendor.js` is changed: Previous: ``` ``` Current: ``` __webpack_exports__["default"] = ("<Frame defaultPage=\"bundle-main-page\" id=\"root-frame1\">\n</Frame>\n"); ``` On the other side, angular updated `raw-loader` to v3.1.0 in their latest minor release e.g in v8.3.0. As a result, `tns test` command doesn't work for newly created code shared applications. This PR adds support for parsing xml modules exported via ES module export syntax.
manoldonev
changed the title
Fatme
changed the title
manoldonev
approved these changes
Oct 8, 2019
|
test tsapps ngapps |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The raw-loader changed the way the modules are exported e.g they've already used ES Module export instead of CommonJS. This way, the format of modules inside
bundle.jsorvendor.jsis changed:Previous:
Current:
On the other side, angular updated
raw-loaderto v3.1.0 in their latest minor release e.g in v8.3.0. As a result,tns testcommand doesn't work for newly created code shared applications.This PR adds support for parsing xml modules exported via ES module export syntax.
Rel to: #7915
PR Checklist
What is the current behavior?
What is the new behavior?
Fixes/Implements/Closes #[Issue Number].