Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: xml parsing when input value is reported as object instead of string #7916

Merged
merged 4 commits into from
Oct 9, 2019
Merged

fix: xml parsing when input value is reported as object instead of string #7916

merged 4 commits into from
Oct 9, 2019

Commits on Oct 8, 2019

  1. fix: fix parsing of xml files when input value is reported as object … 

    …instead of string

The [raw-loader](https://github.com/webpack-contrib/raw-loader/blob/6cf76b8947d34fcbe2c11fabc0a995cbf246615f/src/index.js#L18) changed the way they export modules e.g they've already used ES Module export instead of CommonJS. This way, the format of modules inside `bundle.js` or `vendor.js` is changed:
Previous:
```

```

Current:
```
 __webpack_exports__["default"] = ("<Frame defaultPage=\"bundle-main-page\" id=\"root-frame1\">\n</Frame>\n");
```

On the other side, angular updated `raw-loader` to v3.1.0 in their latest minor release e.g in v8.3.0. As a result, `tns test` command doesn't work for newly created code shared applications.

This PR adds support for parsing xml modules exported via ES module export syntax.
    @Fatme
    Fatme committed Oct 8, 2019
    Configuration menu
    Copy the full SHA
    c7ae77d View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into fatme/fix-xml-parsing

    @manoldonev
    manoldonev committed Oct 8, 2019
    Configuration menu
    Copy the full SHA
    1c1bc0a View commit details
    Browse the repository at this point in the history

  3. refactoring

    @manoldonev
    manoldonev committed Oct 8, 2019
    Configuration menu
    Copy the full SHA
    34c2573 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into fatme/fix-xml-parsing

    @SvetoslavTsenov
    SvetoslavTsenov committed Oct 8, 2019
    Configuration menu
    Copy the full SHA
    c230e41 View commit details
    Browse the repository at this point in the history