Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implementing 'onBackPressed' for frame-root. Useful for meddling with tab-navigated apps #8634

Merged
merged 6 commits into from Jun 13, 2020

Conversation

CatchABus
Copy link
Contributor

@CatchABus CatchABus commented Jun 12, 2020

PR Checklist

What is the current behavior?

Currently, 'onBackPressed' callback will never get called in the case of a frame root.

What is the new behavior?

Developers will be able to handle back press for frame root.

@CatchABus CatchABus changed the title Implementing 'onBackPressed' for frame-root. Useful for meddling with… feat: Implementing 'onBackPressed' for frame-root. Useful for meddling with tab-navigated apps Jun 12, 2020
@NathanaelA

This comment was marked as abuse.

@cla-bot cla-bot bot added the cla: yes label Jun 13, 2020
@cla-bot
Copy link

cla-bot bot commented Jun 13, 2020

The cla-bot has been summoned, and re-checked this pull request!

@cla-bot
Copy link

cla-bot bot commented Jun 13, 2020

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla.
CLA has not been signed by users: @dimitrisdnr.
After signing the CLA, you can ask me to recheck this PR by posting @cla-bot check as a comment to the PR.

@cla-bot cla-bot bot removed the cla: yes label Jun 13, 2020
@cla-bot
Copy link

cla-bot bot commented Jun 13, 2020

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla.
CLA has not been signed by users: @dimitrisdnr.
After signing the CLA, you can ask me to recheck this PR by posting @cla-bot check as a comment to the PR.

@CatchABus
Copy link
Contributor Author

@cla-bot check

@cla-bot cla-bot bot added the cla: yes label Jun 13, 2020
@cla-bot
Copy link

cla-bot bot commented Jun 13, 2020

The cla-bot has been summoned, and re-checked this pull request!

@NathanWalker
Copy link
Contributor

Great contribution @dimitrisrk thank you!

@NathanWalker NathanWalker merged commit c73952f into NativeScript:master Jun 13, 2020
@NathanWalker
Copy link
Contributor

@dimitrisrk published in 6.5.6 now 🤗

NathanWalker pushed a commit that referenced this pull request Aug 7, 2020
Useful for meddling with tab-navigated apps.

Co-authored-by: Dimitris - Rafail Katsampas <katsampasdr@gmail.com>
NathanWalker pushed a commit that referenced this pull request Aug 7, 2020
Useful for meddling with tab-navigated apps.

Co-authored-by: Dimitris - Rafail Katsampas <katsampasdr@gmail.com>
tarunama pushed a commit to tarunama/NativeScript that referenced this pull request Sep 9, 2020
…ipt#8634)

Useful for meddling with tab-navigated apps.

Co-authored-by: Dimitris - Rafail Katsampas <katsampasdr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants