New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(webpack5): angular scss rule not ignoring regular scss #9502

Merged

rigor789 merged 2 commits into master from fix/webpack5-angular-scss

Aug 9, 2021

Contributor

edusperoni commented Aug 9, 2021

PR Checklist

The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages.
There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it.
You have signed the CLA.
All existing tests are passing: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/DevelopmentWorkflow.md#running-unit-tests-application.
Tests for the changes are included - https://github.com/NativeScript/NativeScript/blob/master/tools/notes/WritingUnitTests.md.

What is the current behavior?

What is the new behavior?

Fixes #9499.


          fix(webpack5): angular scss rule not ignoring regular scss

5ecc98f

cla-bot bot added the cla: yes label

edusperoni requested a review from rigor789

August 9, 2021 17:30


          test: angular scss snapshot update

16c4f0d

rigor789 approved these changes

View reviewed changes

rigor789 merged commit 093b369 into master

rigor789 deleted the fix/webpack5-angular-scss branch

August 9, 2021 17:42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels