Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Do not redraw on iOS if background image is 'none' #9800

Merged
merged 1 commit into from
Mar 1, 2022
Merged

Conversation

sebj54
Copy link
Contributor

@sebj54 sebj54 commented Mar 1, 2022

PR Checklist

What is the current behavior?

On iOS, views with background-image: none are redrawn multiple times while they shouldn't. Even if you just set a background-color, background-image is automatically set to none (I don't know what is setting this value though).

What is the new behavior?

Views are redrawn only if the view has a background-image, a non-uniform border or a border radius.

Additional information

I identified this problem because my app crashed because of a constantly redrawn background. This PR does not fix the problem in my app (I made other app-specific changes) but I thought that the change is still needed for better performance.

I also could not run the tests (I think the README is outdated because the tests folder does not exist).

@cla-bot cla-bot bot added the cla: yes label Mar 1, 2022
@NathanWalker NathanWalker changed the base branch from master to release/8.2.0 March 1, 2022 20:13
@NathanWalker NathanWalker merged commit 402a7bb into NativeScript:release/8.2.0 Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants