New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): Media query support #10530
Draft
CatchABus
wants to merge
61
commits into
NativeScript:main
Choose a base branch
from
CatchABus:media-query-support
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CatchABus
force-pushed
the
media-query-support
branch
from
April 30, 2024 00:34
49e353b
to
6fdadee
Compare
CatchABus
force-pushed
the
media-query-support
branch
from
May 5, 2024 16:45
fe788de
to
5c21bda
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
Core is missing support for media queries.
What is the new behavior?
CSS media queries, MediaQueryList, and method matchMedia implementation.
To parse the queries, we are porting css-mediaquery to core rewritten in TypeScript. This one is quite old and supports up to Level 3 specs but we can replace it when we find one that's compatible with {N}.
Keyframes rules improvements are also included as they were poorly implemented before.
Supported media features:
Usage
matchMedia
Common media query
Common media query with nested keyframes
Nested media query
Implements/Closes #64 NativeScript/rfcs#46 .
Fixes #6314