Fixes breaking app on back btn clearHistory: true on android #1637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @hshristov @enchev |
|
👍 |
|
run ci |
ErjanGavalji
changed the title
|
@atanasovg I'm working on this issue and it seems there are few bugs - one crash, one memory leak and one issue where page stays empty on navigating back. So I think it will be better to fix them all at once because they seems related. Once I'm ready I will push another PR. So we can close this for the moment, ok? |
|
👍 |
hshristov
pushed a commit
that referenced
this pull request
Feb 25, 2016
…learhistory Fixes breaking app on back btn clearHistory: true on android
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull fixes #1569. The problem was that the
clearHistoryoption resets the_currentEntryfield and theexpression returned true when it is actually false and this corrupts the native Android backstack.