Fix for Dialogs crashing on iOS #2866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
7 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
run ci |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new cool Pseudo selector cool have a negative interaction with Dialogs; the code will now create a "NSInternalInconsistencyException" later in an iOS application. (Depending on when GC occurs)
The issue is that the dialog-common creates a new button, applies the CSS selector and grabs its color. The process of applying the CSS selector causes the pseudo selector code to be registered via the _updateHandler code inside the button.ios.ts file. For every "observer" registered, you must de-register it before deallocation. However, since the "onUnloaded" code is never called (because the button is not actually put into the DOM) the observer is never un-registered. This patch manually calls the onUnloaded() function which de-registers the observer so everything is great again.
The commit message references a specific issue in this repo
Fixes NativeScript/ios-jsc#665