Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Camera gallery as image source. #2989

Closed
wants to merge 1 commit into from
Closed

Camera gallery as image source. #2989

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Oct 30, 2016

This also fixes a bug that would show video as an option when it shouldn't on iOS, since video is not yet implemented.

@ns-bot
Copy link

ns-bot commented Oct 30, 2016

Can one of the admins verify this patch?

8 similar comments
@ns-bot
Copy link

ns-bot commented Oct 30, 2016

Can one of the admins verify this patch?

@ns-bot
Copy link

ns-bot commented Oct 30, 2016

Can one of the admins verify this patch?

@ns-bot
Copy link

ns-bot commented Oct 30, 2016

Can one of the admins verify this patch?

@ns-bot
Copy link

ns-bot commented Oct 30, 2016

Can one of the admins verify this patch?

@ns-bot
Copy link

ns-bot commented Oct 30, 2016

Can one of the admins verify this patch?

@ns-bot
Copy link

ns-bot commented Oct 30, 2016

Can one of the admins verify this patch?

@ns-bot
Copy link

ns-bot commented Oct 30, 2016

Can one of the admins verify this patch?

@ns-bot
Copy link

ns-bot commented Oct 30, 2016

Can one of the admins verify this patch?

@nsndeck
Copy link

nsndeck commented Nov 7, 2016

Thank you for your pull request.

First of all we plan to deprecate build-in tns-core-modules camera module so we extract current functionality to a plugin named nativescript-camera. For that plugin we received similar pull request (adding different sources for images). However we provide same functionality with another pluigin nativescript-imagepicker. Therefore our plans is to provide camera hardware only access via nativescript-camera plugin.

@ghost ghost closed this Nov 7, 2016
@ghost ghost deleted the camera-gallery-source branch November 7, 2016 11:37
@lock
Copy link

lock bot commented Aug 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Aug 28, 2019
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants