Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ios): fire onDisplayed event when first frame is ready to be displayed #5344

Merged
merged 3 commits into from
Jan 29, 2018

Conversation

sis0k0
Copy link
Contributor

@sis0k0 sis0k0 commented Jan 27, 2018

This PR is just the iOS part of #5316.

@ghost ghost assigned sis0k0 Jan 27, 2018
@ghost ghost added the in progress label Jan 27, 2018
@SvetoslavTsenov
Copy link
Contributor

cuteness

@SvetoslavTsenov
Copy link
Contributor

👍
Tests looks fine so far, ping @PanayotCankov.

@SvetoslavTsenov
Copy link
Contributor

test

1 similar comment
@SvetoslavTsenov
Copy link
Contributor

test

@vakrilov vakrilov merged commit 1c78e47 into master Jan 29, 2018
@vakrilov vakrilov deleted the profiling-lifecycle-ios branch January 29, 2018 11:47
sis0k0 added a commit that referenced this pull request Feb 5, 2018
…played (#5344)

* feat: add a 'profiling: lifecycle' to track startup times

* feat: log when displayed event fires

* feat(ios): fire onDisplayed event when first frame is ready to be
displayed
vakrilov pushed a commit that referenced this pull request Feb 13, 2018
* refactor: Handle TS2.7 stricter tuples checks (#5366)

* feat(ios): fire onDisplayed event when first frame is ready to be displayed (#5344)

* feat: add a 'profiling: lifecycle' to track startup times

* feat: log when displayed event fires

* feat(ios): fire onDisplayed event when first frame is ready to be
displayed

* chore: bump version to 3.4.1
@dtopuzov dtopuzov added this to the 3.4.1 milestone Feb 20, 2018
@lock
Copy link

lock bot commented Aug 26, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Aug 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants