fix(bottom-navigation): created dynamically does not show tabstrip #7624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
does not show tabstrip
ADjenkov
force-pushed
the
djenkov/bottom-nav-codebehind
branch
from
c502827
to
b30732f
Compare
MartoYankov
approved these changes
Aug 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[iOS]: execute
setViewControllerswhen setting.tabStripproperty to populate all tabStrip and tabContent items. Thus, there is no need to worry with property (items/tabStrip) is set first.[Android]:
onTabStripChangedwas adding TabStripItem child views in BottomNavigation directly, instead of just adding the new TabStrip as a child view.Fix: #7433