fix(ios): label measure correct height when using custom numberOfLines #9945
Conversation
|
Thank you 🙏 |
| @@ -104,7 +104,7 @@ export class Label extends TextBase implements LabelDefinition { | |||
| private _measureNativeView(width: number, widthMode: number, height: number, heightMode: number): { width: number; height: number } { | |||
| const view = <UILabel>this.nativeTextViewProtected; | |||
|
|
|||
| const nativeSize = view.textRectForBoundsLimitedToNumberOfLines(CGRectMake(0, 0, widthMode === 0 /* layout.UNSPECIFIED */ ? Number.POSITIVE_INFINITY : layout.toDeviceIndependentPixels(width), heightMode === 0 /* layout.UNSPECIFIED */ ? Number.POSITIVE_INFINITY : layout.toDeviceIndependentPixels(height)), 0).size; | |||
| const nativeSize = view.textRectForBoundsLimitedToNumberOfLines(CGRectMake(0, 0, widthMode === 0 /* layout.UNSPECIFIED */ ? Number.POSITIVE_INFINITY : layout.toDeviceIndependentPixels(width), heightMode === 0 /* layout.UNSPECIFIED */ ? Number.POSITIVE_INFINITY : layout.toDeviceIndependentPixels(height)), view.numberOfLines).size; | |||
There was a problem hiding this comment.
This will be a breaking change and thus targeting 8.3 however we should regression test with this due to fact this would not default to 0 as it was this way anymore.
https://developer.apple.com/documentation/uikit/uilabel/1620539-numberoflines
The default value for this property is 1. To remove any maximum limit, and use as many lines as needed, set the value of this property to 0.
There was a problem hiding this comment.
@NathanWalker Yes, the default native value is 1, but on {N} setting textWrap to true (or the whiteSpace style) sets it to 0, and this _measureNativeView method is only called when textWrap is true, otherwise it uses layout.measureNativeView.
Following the code path I don't see any way that this is called with the value of 1 unless the user sets the numberOfLines prop to 1 explicitly
There was a problem hiding this comment.
Great analysis @mukaschultze I'm going to include this on the next 8.3.x alpha - we are beginning to qualify things around the next minor and would make great candidate for that at any rate. Thanks for your effort here.
NathanWalker
changed the title
numberOfLines for iOS labels
PR Checklist
What is the current behavior?
Right now, iOS labels include all the lines on the height measurement and do not respect the value specified by the
numberOfLinesproperty.What is the new behavior?
The new behavior respects the
numberOfLinesproperty and properly measures the label height. When the user doesn't specify a custom value for the property it'll be zero and thus all the lines will be considered in the measurement, just as before.Fixes #6037