Skip to content

Commit

Permalink
fix: intermediary fix for #1771
Browse files Browse the repository at this point in the history
  • Loading branch information
edusperoni committed Jul 18, 2023
1 parent 16abf31 commit 32c7abb
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions test-app/runtime/src/main/cpp/MetadataNode.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -945,6 +945,9 @@ void MetadataNode::SetInnerTypes(Isolate* isolate, Local<Function>& ctorFunction
}
auto innerTypeCtorFunc = Local<Function>::New(isolate, *GetOrCreateInternal(curChild)->GetPersistentConstructorFunction(isolate));
auto innerTypeName = ArgConverter::ConvertToV8String(isolate, curChild->name);
// TODO: remove this once we solve https://github.com/NativeScript/android/pull/1771
// this avoids a crash, but the companion object is still unaccessible
TryCatch tc(isolate);
ctorFunction->Set(context, innerTypeName, innerTypeCtorFunc);
}
}
Expand Down

0 comments on commit 32c7abb

Please sign in to comment.