perf: avoid unnecessary string copying when calling static properties…

… of interfaces
NativeScript · Jun 28, 2023 · 8b53d02 · 8b53d02
1 parent 88ce2d8
commit 8b53d02
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/test-app/runtime/src/main/cpp/DesugaredInterfaceCompanionClassNameResolver.cpp b/test-app/runtime/src/main/cpp/DesugaredInterfaceCompanionClassNameResolver.cpp
@@ -1,11 +1,11 @@
 #include "DesugaredInterfaceCompanionClassNameResolver.h"
 
 std::string DesugaredInterfaceCompanionClassNameResolver::resolveD8InterfaceCompanionClassName(
-        std::string interfaceName) {
+        const std::string& interfaceName) {
     return interfaceName + D8_COMPANION_CLASS_SUFFIX;
 }
 
 std::string DesugaredInterfaceCompanionClassNameResolver::resolveBazelInterfaceCompanionClassName(
-        std::string interfaceName) {
+        const std::string& interfaceName) {
     return interfaceName + BAZEL_COMPANION_CLASS_SUFFIX;
 }
diff --git a/test-app/runtime/src/main/cpp/DesugaredInterfaceCompanionClassNameResolver.h b/test-app/runtime/src/main/cpp/DesugaredInterfaceCompanionClassNameResolver.h
@@ -7,9 +7,9 @@
 class DesugaredInterfaceCompanionClassNameResolver {
 
 public:
-    std::string resolveD8InterfaceCompanionClassName(std::string interfaceName);
+    std::string resolveD8InterfaceCompanionClassName(const std::string& interfaceName);
 
-    std::string resolveBazelInterfaceCompanionClassName(std::string interfaceName);
+    std::string resolveBazelInterfaceCompanionClassName(const std::string& interfaceName);
 
 private:
     const std::string BAZEL_COMPANION_CLASS_SUFFIX = "$$CC";