Skip to content

Commit

Permalink
fix: Leave context after Runtime::PrepareV8Runtime()
Browse files Browse the repository at this point in the history
In PrepareV8Runtime() we enter the context but never leave it. This is
mostly harmless but fails a DCHECK because when we leave the scope of the
Locker, there is not supposed to be an entered context.
  • Loading branch information
ptomato authored and edusperoni committed Jun 23, 2023
1 parent 6cdc705 commit cd1d285
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion test-app/runtime/src/main/cpp/Runtime.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -588,7 +588,7 @@ Isolate* Runtime::PrepareV8Runtime(const string& filesPath, const string& native

auto global = context->Global();

context->Enter();
v8::Context::Scope contextScope{context};

m_objectManager->Init(isolate);

Expand Down

0 comments on commit cd1d285

Please sign in to comment.