Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Xcode14 build #1297

Merged
merged 2 commits into from
Sep 22, 2022
Merged

fix: Xcode14 build #1297

merged 2 commits into from
Sep 22, 2022

Conversation

PeterStaev
Copy link
Contributor

@PeterStaev PeterStaev commented Sep 13, 2022

PR Checklist

What is the current behavior?

App using the JSC fails to compile using XCode14

What is the new behavior?

Fixes app build with Xcode 14.

Changes taken from NativeScript/ios@3b1eafc

Fixes/Implements/Closes #[Issue Number].

@cla-bot cla-bot bot added the cla: yes label Sep 13, 2022
@PeterStaev
Copy link
Contributor Author

@rigor789 / @NathanWalker can we get this reviewed, merged and a new version of the JSC runtime pushed over to NPM. Have an app that I need to build against latest SDKs.

Copy link
Member

@rigor789 rigor789 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, will try to get this published by eod

@rigor789 rigor789 merged commit 5a02eac into NativeScript:master Sep 22, 2022
@PeterStaev PeterStaev deleted the feature/xcode14 branch September 22, 2022 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants